tests: add 'expo_force' tests #7744
Conversation
src/tests/system/tests/test_ldap.py
Outdated
| @@ -14,8 +16,8 @@ | |||
|
|
|||
| @pytest.mark.ticket(bz=[795044, 1695574]) | |||
| @pytest.mark.importance("critical") | |||
| @pytest.mark.authentication | |||
| @pytest.mark.parametrize("modify_mode", ["exop", "ldap_modify"]) | |||
| @pytest.mark.builtwith("exop_force") | |||
There was a problem hiding this comment.
Thim might skip the test altogether when the exop_force is missing but other ways to change password are available..
There was a problem hiding this comment.
Which scenario would that be where exop_force is missing but other ways are available? The exop_foce is available in this branch.
What's your alternate suggestion?
There was a problem hiding this comment.
Can You provide a reference to the tickets introducing exop_force?
Easiest way would be creating standalone test with proper mark.ticket and requirement in metadata so we have the traceability in polarion.
There was a problem hiding this comment.
shared the details internally
shridhargadekar
force-pushed
the
exop4
branch
from
097070b to
8534ed1
Compare
src/tests/system/tests/test_ldap.py
Outdated
| 3. Set "passwordGraceLimit" to "0" | ||
| 4. Add a user to LDAP | ||
| 5. Wait until the password is expired | ||
| 6. Set "ldap_pwmodify_mode" |
There was a problem hiding this comment.
Same here, although I admit this will be more difficult due to the parametrization, but I'm sure you can find something more meaningful
There was a problem hiding this comment.
Not sure how to rearrange this. Keeping as it is.
There was a problem hiding this comment.
How about Specify the operation to be used to change the password in the parametrization?
shridhargadekar
force-pushed
the
exop4
branch
from
8534ed1 to
4f05fb1
Compare
| client.sssd.start() | ||
|
|
||
| rc, _, _, _ = client.auth.parametrize(method).password_with_output("user1", "Secret123") | ||
| assert rc == expected, err_msg |
There was a problem hiding this comment.
This could use line or two of explaining comment what is going on.
There was a problem hiding this comment.
IMO steps and expectedresults already explain it, but if you see the need for any additional explanation, I will not prevent it
shridhargadekar
force-pushed
the
exop4
branch
from
4f05fb1 to
6eaf502
Compare
The new value for the ldap_pwmodify_mode option 'exop_force' is added to existing test. A new test to illustrate the different behavior of 'exop' and 'exop_force' is added. Reviewed-by: Justin Stephenson <[email protected]> Reviewed-by: Pavel Březina <[email protected]> (cherry picked from commit deefe9a)
shridhargadekar
force-pushed
the
exop4
branch
from
6eaf502 to
d9eb0f3
Compare
@shridhargadekar, @jakub-vavra-cz, IIUC, feature detection was merged, so PR can be updated? Besides, what branches does it target? |
The new value for the ldap_pwmodify_mode option 'exop_force' is added to existing test. A new test to illustrate the different behavior of 'exop' and 'exop_force' is added.
Reviewed-by: Justin Stephenson [email protected]
Reviewed-by: Pavel Březina [email protected]
(cherry picked from commit deefe9a)