-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make failover work over IP families #7658
Conversation
@thalman, could you please add a release note (or convert commit message to a release note)? |
done |
All system tests fail.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, other than that, it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
I spoke too soon, its failing CI.
Changing the topology marker to, should fix the problem.
|
Failing CI, will re-approve when it's green.
mea culpa, it should be fixed now, lets wait for green |
39bfd95
to
2371e23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failure is not related to the patch, approving.
Originally the option ipv4_first and ipv6_first was taken into account when resolving IP address. When both families are resolvable but the primary is blocked on firewall, the SSSD should try the secondary family before giving up. :relnote:SSSD now attempts to connect to the server using a secondary protocol if the server is not reachable using the primary one. See the lookup_family_order option.
Test that IPA server is still reachable when primary address family is blocked but secondary is working.
Originally the option ipv4_first and ipv6_first was taken into account
when resolving IP address.
When both families are resolvable but the primary is blocked on
firewall, the SSSD must switch to the socondary family.