Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC: clean up mem-cache files on uninstall #7140

Closed
wants to merge 1 commit into from

Conversation

alexey-tikhonov
Copy link
Member

@alexey-tikhonov alexey-tikhonov commented Jan 19, 2024

instead of tracking those files as a part of package.

This will allow to get rid of fchown() in responder/nss/nsssrv_mmap_cache.c

@alexey-tikhonov alexey-tikhonov changed the title SPEC: todo SPEC: clean up mem and ldb cache files on uninstall Jan 19, 2024
@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. non-privileged labels Jan 19, 2024
@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review January 19, 2024 21:08
Copy link
Contributor

@justin-stephenson justin-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thank you.

contrib/sssd.spec.in Outdated Show resolved Hide resolved
@alexey-tikhonov alexey-tikhonov force-pushed the spec-clean-mc branch 2 times, most recently from 936530d to ce43ab6 Compare January 26, 2024 15:20
@pbrezina
Copy link
Member

Hmm... one thing popped in my mind and that is that if you uninstall sssd you also loose data for local overrides which cannot be recovered. I believe that if someone uninstalls sssd that all data should be removed, but I'm little bit on the edge here. @sumit-bose what do you think?

@alexey-tikhonov
Copy link
Member Author

(rebase)

@alexey-tikhonov
Copy link
Member Author

Hmm... one thing popped in my mind and that is that if you uninstall sssd you also loose data for local overrides which cannot be recovered. I believe that if someone uninstalls sssd that all data should be removed, but I'm little bit on the edge here.

@pbrezina, I moved ldb-cache related part into PR on its own - #7150 (on top of this PR)

Main (more important) point of this PR is to get rid of %attr(0664,%{sssd_user},%{sssd_user}) for mem-cache files.

@alexey-tikhonov alexey-tikhonov changed the title SPEC: clean up mem and ldb cache files on uninstall SPEC: clean up mem-cache files on uninstall Jan 29, 2024
contrib/sssd.spec.in Outdated Show resolved Hide resolved
instead of tracking those files as a part of a package.

This will allow to get rid of `fchown()` in responder/nss/nsssrv_mmap_cache.c
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for the patch, ACK.

bye,
Sumit

@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7140

  • master
    • ec77ec4 - SPEC: clean up mem-cache files on uninstall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. non-privileged Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants