-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPEC: clean up mem-cache files on uninstall #7140
Conversation
cd38493
to
8459d1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, thank you.
936530d
to
ce43ab6
Compare
Hmm... one thing popped in my mind and that is that if you uninstall sssd you also loose data for local overrides which cannot be recovered. I believe that if someone uninstalls sssd that all data should be removed, but I'm little bit on the edge here. @sumit-bose what do you think? |
ce43ab6
to
6fb9306
Compare
(rebase) |
6fb9306
to
459abb2
Compare
@pbrezina, I moved ldb-cache related part into PR on its own - #7150 (on top of this PR) Main (more important) point of this PR is to get rid of |
instead of tracking those files as a part of a package. This will allow to get rid of `fchown()` in responder/nss/nsssrv_mmap_cache.c
459abb2
to
a1dac07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
thanks for the patch, ACK.
bye,
Sumit
instead of tracking those files as a part of package.
This will allow to get rid of
fchown()
in responder/nss/nsssrv_mmap_cache.c