Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make config files permissions consistent. #6841

Closed
wants to merge 3 commits into from
Closed

Make config files permissions consistent. #6841

wants to merge 3 commits into from

Conversation

alexey-tikhonov
Copy link
Member

No description provided.

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Jul 18, 2023
@alexey-tikhonov alexey-tikhonov force-pushed the cfg-permissions branch 2 times, most recently from 7fc4bd0 to 67ab185 Compare July 20, 2023 13:24
@alexey-tikhonov alexey-tikhonov force-pushed the cfg-permissions branch 2 times, most recently from fb6f198 to 73c5a7e Compare July 20, 2023 14:51
@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review July 20, 2023 20:20
aplopez
aplopez reviewed Jul 21, 2023
View reviewed changes
src/man/sssd.conf.5.xml Outdated Show resolved Hide resolved
contrib/sssd.spec.in Outdated Show resolved Hide resolved
contrib/sssd.spec.in Outdated Show resolved Hide resolved
@andreboscatto andreboscatto requested a review from pbrezina July 25, 2023 12:38
@alexey-tikhonov
SPEC: make permissions of config folders consistent
adfdd76 
It doesn't make	sense to allow 'go+x' for sub-folders under
'/etc/sssd' since this folder itself doesn't have those	permissions.
@alexey-tikhonov
TOOLS: get rid of strings duplications
7f81e61
@alexey-tikhonov
SPEC: make ownership of sssd.conf consistent with
0764f07 
config folders.

:packaging: sssd.conf should be owned by user specified
with '--with-sssd-user=' at build time. If SSSD runs under
'root' then 'root' ownership of this file will be also
allowed in runtime.
aplopez
aplopez approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pbrezina
Copy link
Member

pbrezina commented Aug 7, 2023

Pushed PR: #6841

  • master
    • 91d32fe - SPEC: make ownership of sssd.conf consistent with config folders.
    • a540f91 - TOOLS: get rid of strings duplications
    • 7902bd6 - SPEC: make permissions of config folders consistent

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Aug 7, 2023
@pbrezina pbrezina closed this Aug 7, 2023
@alexey-tikhonov
Copy link
Member Author

This PR missed check of snippets:

sssd/src/util/sss_ini.c

Line 297 in 16d3308

snip_check.uid = 0; /* owned by root */

I'm thinking how to address it.

@alexey-tikhonov alexey-tikhonov mentioned this pull request Sep 26, 2023
Closed
@alexey-tikhonov alexey-tikhonov mentioned this pull request Mar 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-stephenson justin-stephenson justin-stephenson left review comments

@pbrezina pbrezina pbrezina approved these changes

@aplopez aplopez aplopez approved these changes

Assignees

@aplopez aplopez

@pbrezina pbrezina

Labels
no-backport This should go to target branch only. non-privileged Pushed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexey-tikhonov @pbrezina @justin-stephenson @aplopez