Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial import #2

Merged
merged 10 commits into from
Jan 7, 2025
Merged

Initial import #2

merged 10 commits into from
Jan 7, 2025

Conversation

barulicm
Copy link
Contributor

@barulicm barulicm commented Jan 4, 2025

Imports relevant packages and documentation to get the repo started.

Details:

  • Most code files are minimally modified from the versions in our software repo.
  • The game controller bridge and vision bridge packages have been merged into the new ssl_ros_bridge package.
  • Utilities from ateam_common have been copied into ssl_ros_bridge. Not worth the hassle for now to avoid maintaining duplicates between the two repos IMO.
  • Interface types (messages & services) used by these bridge nodes have been moved to the new ssl_ros_bridge_msgs package.

I've got a short list of improvements that could be made to this code. I'll open issues to track those soon. What we've got here works enough to go ahead and get it in.

Copy link

@chachmu chachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything builds on my machine but I didn't check if there were any dependencies that should be installed since I just have them already

@barulicm barulicm merged commit 6479501 into main Jan 7, 2025
1 check passed
@barulicm barulicm deleted the dev/barulicm/init branch January 7, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants