Fix Maven publication #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
force-pushed
the
fix_publication
branch
from
7e8614e to
fee046f
Compare
Loic-Dumas
approved these changes
Dec 11, 2024
|
Nice idea for the local publication in code quality. |
I've added it to the list of required checks on PRs in the branch protection rules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with Maven publication when using Java 17.
I wasn't able to figure out the exact cause, but using Java 11 seems to work fine, so I've updated the project to use that version.
I've also updated the
code_quality.ymlworkflow to add a step to publish to Maven local, so we can always ensure that publication works.The error that was happening can be seen in the build log of the first commit: https://github.com/SRGSSR/srgdataprovider-android/actions/runs/12274751507/job/34248321537?pr=64