Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont add vector if already present in url. #43

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Dont add vector if already present in url. #43

merged 2 commits into from
Jun 11, 2024

Conversation

Loic-Dumas
Copy link
Contributor

This PR prevent vector to be added twice if already present in the URL.

Fix issue #42

@Loic-Dumas Loic-Dumas requested review from MGaetan89 and StaehliJ June 10, 2024 13:02
MGaetan89
MGaetan89 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

StaehliJ
StaehliJ approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, maybe use setQueryParameters ? But the provided solution suits me.

@StaehliJ StaehliJ added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 0effa7a Jun 11, 2024
5 checks passed
@StaehliJ StaehliJ deleted the Dont-add-vector-if-already-present branch June 11, 2024 06:40
@MGaetan89 MGaetan89 linked an issue Aug 30, 2024 that may be closed by this pull request
SAM can't accept twice the same parameter. #42
Closed
1 task
@MGaetan89 MGaetan89 mentioned this pull request Aug 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAM can't accept twice the same parameter.
3 participants
@Loic-Dumas @MGaetan89 @StaehliJ