Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle configuration and GitHub Action workflow #40

Merged
merged 6 commits into from
May 21, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented May 15, 2024

Changes made

  • Update the code_quality.yml workflow to use the latest actions versions.
  • Make Android Lint and Detekt generate SARIF files to be used by the code_quality.yml workflow.
  • Let the code_quality.yml workflow run for any PR, even in draft.
  • Remove unused dependencies from each modules.
  • Remove unused KAPT Gradle plugin.
  • Disable unused features in Android Gradle Plugin (BuildConfig, res value and shaders generation).

Notes

  • No project dependencies have been updated in this PR.
  • I didn't update the data provider version, as this doesn't need a dedicated release.
  • If these changes should be merged, the branch protection rule needs to be updated to use the new validation names (Android Lint, Detekt, and Unit Test).

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@MGaetan89 MGaetan89 self-assigned this May 15, 2024
@MGaetan89 MGaetan89 marked this pull request as ready for review May 15, 2024 10:31
@MGaetan89 MGaetan89 requested review from StaehliJ and Loic-Dumas May 15, 2024 10:31
Copy link
Contributor

@Loic-Dumas Loic-Dumas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.
However, I'm not familiar with Github CI. So maybe wait @StaehliJ feedback before merging if it's not urgent.

@MGaetan89
Copy link
Member Author

MGaetan89 commented May 15, 2024

It's not urgent, so I can wait for his review.
I've reused what we did in pillarbox-android for the CI.

@MGaetan89 MGaetan89 added the enhancement New feature or request label May 21, 2024
@StaehliJ StaehliJ enabled auto-merge May 21, 2024 13:58
@StaehliJ StaehliJ added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 62ddb7b May 21, 2024
5 checks passed
@StaehliJ StaehliJ deleted the update_gradle_config_github_action branch May 21, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants