Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAYNEXT-487 iOS 18 app icon #522

Merged
merged 3 commits into from
Dec 5, 2024
Merged

PLAYNEXT-487 iOS 18 app icon #522

merged 3 commits into from
Dec 5, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Oct 21, 2024 •
edited
Loading

Description

Apple introduced new rules for iOS 18 app icon.

Changes Made

  • Update to a single app icon.
  • Update with Play SRF appearance icons.

ℹ️ Still building with Xcode 15.4. Let's try (poker face 🙈)

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added the improvement Feature or update (issue and PR) - release notes section label Oct 21, 2024
@pyby pyby marked this pull request as draft October 21, 2024 15:04
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYNEXT-487-ios18-app-icon-test October 21, 2024 15:06 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-487-ios18-app-icon-test October 21, 2024 15:06 Inactive
@pyby
Copy link
Member Author

pyby commented Oct 22, 2024

Test failed. Building with Xcode 15.4 does not take new appearance icons.

  • screenshots: see nighties only. Debugs are from an other branch and an other issue.
    IMG_0106_2
    IMG_0108

With the icon dark mode on, only Apple app icons and Pillarbox apps had switched to the dark one.

@pyby pyby closed this Oct 22, 2024
@mutaben mutaben reopened this Dec 5, 2024
@mutaben mutaben marked this pull request as ready for review December 5, 2024 09:09
@mutaben mutaben added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 3baaa00 Dec 5, 2024
6 checks passed
@mutaben mutaben deleted the PLAYNEXT-487-ios18-app-icon-test branch December 5, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutaben mutaben mutaben approved these changes

Assignees
No one assigned
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyby @mutaben @rts-devops