Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add emoji for debug and nigthly build #839

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Add emoji for debug and nigthly build #839

merged 4 commits into from
Dec 19, 2024

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

Add prefix emoji to differentiate builds.

  • 🐛 Pillarbox Demo Debug
  • 🌙 Pillarbox Demo Nightly

Changes made

  • Self-explanatory

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Dec 18, 2024 that may be closed by this pull request
Differentiate demo build type #832
Closed
@StaehliJ StaehliJ requested a review from MGaetan89 December 18, 2024 08:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Code Coverage

Overall Project 52.15% 🟢

There is no coverage information present for the Files changed

MGaetan89
MGaetan89 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻
Just a couple suggestions/questions.

app_name is also defined in src/nightlyDebug/res/values/strings.xml.
Does it make sense to have that definition, since the nightly flavor is only enabled on CI, where we do a release build?

pillarbox-demo/src/debug/res/values/strings.xml Outdated Show resolved Hide resolved
pillarbox-demo/src/nightly/res/values/strings.xml Outdated Show resolved Hide resolved
@StaehliJ StaehliJ enabled auto-merge December 19, 2024 09:36
@StaehliJ StaehliJ added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 520f265 Dec 19, 2024
9 checks passed
@StaehliJ StaehliJ deleted the 832-differentiate-demo-build-type branch December 19, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differentiate demo build type
2 participants
@StaehliJ @MGaetan89