Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

802 player time api #814

Merged
merged 13 commits into from
Dec 4, 2024
Merged

802 player time api #814

merged 13 commits into from
Dec 4, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Nov 27, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to provide API and helper to better handle timestamp based stream. Streams may have timestamps information inside their playlist. Media3 is able to extract those informations inside the Timeline.Window.

Pillarbox provide helper to manipulate time based on that information. Those API work only and only if there are timestamp information. Pillarbox doesn't make magic with live streams that haven't timestamp inside the stream.

Changes made

  • Add Player. getUnixTimeMs.
  • Add Player. seekToUnixTimeMs.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Nov 27, 2024 that may be closed by this pull request
Player time API #802
Closed
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Code Coverage

Overall Project 48.58% -0.16% 🟢
Files changed 46.32% 🟢

Module Coverage
:pillarbox-player 56.48% -0.32% 🟢
Files
Module File Coverage
:pillarbox-player ErrorMessageData.kt 49.71% -1.16% 🟢
Player.kt 36.19% -18.28% 🟢

@StaehliJ StaehliJ marked this pull request as ready for review November 28, 2024 13:07
@StaehliJ StaehliJ requested a review from MGaetan89 November 28, 2024 15:06
@StaehliJ StaehliJ added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit bd654de Dec 4, 2024
9 checks passed
@StaehliJ StaehliJ deleted the 802-player-time-api branch December 4, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Player time API
2 participants
@StaehliJ @MGaetan89