Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid send null current chapter when not needed #587

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

The goal of this PR is to avoid sending onChapterChanged(null) when seeking to a chapter start position and the previous chapter end position are the same.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ requested a review from MGaetan89 June 12, 2024 13:53
@StaehliJ StaehliJ added the bug Something isn't working label Jun 12, 2024
Copy link

github-actions bot commented Jun 12, 2024

Code Coverage

Overall Project 50.84% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-player 50.17% 🟢
Files
Module File Coverage
:pillarbox-player TimeRangeTracker.kt 95.53% 🟢

@StaehliJ StaehliJ enabled auto-merge June 12, 2024 14:59
@MGaetan89 MGaetan89 force-pushed the improve-chapter-listening branch from 1703a8b to 0870b3d Compare June 12, 2024 18:26
@StaehliJ StaehliJ added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 794bb54 Jun 12, 2024
10 checks passed
@StaehliJ StaehliJ deleted the improve-chapter-listening branch June 12, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants