Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current time range reset #581

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix current time range reset #581

merged 1 commit into from
Jun 12, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jun 12, 2024

Description

The goal of this PR is to fix a bad behavior with Chapter and Credits. Chapter/Credit changed listener are not called when player seeks back or when current media item changed.

Changes made

  • Correctly notify chapter / Credits changes

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ added the bug Something isn't working label Jun 12, 2024
@StaehliJ StaehliJ self-assigned this Jun 12, 2024
Copy link

github-actions bot commented Jun 12, 2024

Code Coverage

Overall Project 50.81% 🟢
Files changed 94.12% 🟢

Module Coverage
:pillarbox-player 50.11% -0.01% 🟢
Files
Module File Coverage
:pillarbox-player TimeRangeTracker.kt 95.45% -0.2% 🟢

@StaehliJ StaehliJ force-pushed the fix-timerange-not-reset branch from 5d1699e to 85dee13 Compare June 12, 2024 11:30
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@MGaetan89 MGaetan89 added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 8c6c292 Jun 12, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the fix-timerange-not-reset branch June 12, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants