Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert toolchain changes from #556 #563

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Revert toolchain changes from #556 #563

merged 1 commit into from
Jun 4, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jun 4, 2024 •
edited
Loading

Pull request

Description

This PR reverts the toolchain related changes from #556.

The other changes were left untouched (Gradle 8.8 update, Gradle wrapper task configuration, .gitignore updates, ...).

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added the bug Something isn't working label Jun 4, 2024
@MGaetan89 MGaetan89 self-assigned this Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Code Coverage

Overall Project 50.73% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit edefb40 Jun 4, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the partial_revert_556 branch June 4, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels
bug Something isn't working
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGaetan89 @StaehliJ