Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Dependency Analysis plugin only fails for unused dependencies #526

Merged
merged 2 commits into from
May 3, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented May 3, 2024

Pull request

Description

This PR makes the Dependency Analysis plugin fail only for unused dependencies. The other kind of issues are still reported, but are no longer considered as error.

The possible options are:

  • onAny: all kind of issues
  • onUnusedDependencies: unused dependencies
  • onUsedTransitiveDependencies: transitive dependencies used
  • onIncorrectConfiguration: incorrect configuration (mostly api vs implementation)
  • onCompileOnly: a dependency should be compileOnly
  • onRuntimeOnly: a dependency should be runtimeOnly
  • onUnusedAnnotationProcessors: an unused annotation processor is used
  • onRedundantPlugins: a plugin is declared redundantly
  • onModuleStructure: the module structure is wrong

Changes made

Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 self-assigned this May 3, 2024
@MGaetan89 MGaetan89 added the enhancement New feature or request label May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Code Coverage

Overall Project 48.67% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 5630b90 May 3, 2024
10 checks passed
@StaehliJ StaehliJ deleted the analyze_unused_dependencies branch May 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants