Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump android-gradle-plugin from 8.3.2 to 8.4.0 #523

Merged
merged 1 commit into from
May 8, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 1, 2024

Bumps android-gradle-plugin from 8.3.2 to 8.4.0.
Updates com.android.tools.build:gradle-api from 8.3.2 to 8.4.0

Updates com.android.application from 8.3.2 to 8.4.0

Updates com.android.library from 8.3.2 to 8.4.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Code Coverage

Overall Project 48.63% 🟢

There is no coverage information present for the Files changed

@MGaetan89
Copy link
Member

This doesn't seem to break the app, but it generates a bunch of new warnings during build:

Warning: Failed to fetch URL https://dl.google.com/android/repository/sys-img/android-wear-cn/sys-img2-4.xml/sys-img.xml, reason: File not found
Warning: Errors during XML parse:
Warning: https://dl.google.com/android/repository/sys-img/android-wear-cn/sys-img2-4.xml parsing problem. unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: javax.xml.bind.UnmarshalException: unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: Additionally, the fallback loader failed to parse the XML.

We can merge it as is, if the app is indeed working as expected, or wait for version 8.4.1. In both cases, I suggest to wait until after the next release.

@MGaetan89
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/android-gradle-plugin-8.4.0 branch from 7acdeb0 to 9ed7393 Compare May 7, 2024 18:15
@MGaetan89
Copy link
Member

This doesn't seem to break the app, but it generates a bunch of new warnings during build:

Warning: Failed to fetch URL https://dl.google.com/android/repository/sys-img/android-wear-cn/sys-img2-4.xml/sys-img.xml, reason: File not found
Warning: Errors during XML parse:
Warning: https://dl.google.com/android/repository/sys-img/android-wear-cn/sys-img2-4.xml parsing problem. unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: javax.xml.bind.UnmarshalException: unexpected element (uri:"", local:"abi"). Expected elements are <{}vendor>,<{}translatedAbis>,<{}abis>,<{}codename>,<{}base-extension>,<{}api-level>,<{}extension-level>,<{}tag>
Warning: Additionally, the fallback loader failed to parse the XML.

We can merge it as is, if the app is indeed working as expected, or wait for version 8.4.1. In both cases, I suggest to wait until after the next release.

Looks like this is similar to the following issue: https://issuetracker.google.com/issues/337761982.

However, the app seems to be working as expected and the build passes, so I guess we can merge it, now that version 2.0.0 was released.

@MGaetan89 MGaetan89 requested a review from StaehliJ May 8, 2024 06:54
Bumps `android-gradle-plugin` from 8.3.2 to 8.4.0.

Updates `com.android.tools.build:gradle-api` from 8.3.2 to 8.4.0

Updates `com.android.application` from 8.3.2 to 8.4.0

Updates `com.android.library` from 8.3.2 to 8.4.0

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.android.application
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: com.android.library
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@MGaetan89 MGaetan89 force-pushed the dependabot/gradle/android-gradle-plugin-8.4.0 branch from 9ed7393 to 61b89a0 Compare May 8, 2024 08:31
@StaehliJ StaehliJ added this pull request to the merge queue May 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 8, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 950ce8f May 8, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the dependabot/gradle/android-gradle-plugin-8.4.0 branch May 8, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants