-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
451 handle chapters and blocked segments #501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaehliJ
force-pushed
the
451-handle-segment
branch
from
April 17, 2024 14:07
5b4ce98
to
68d74be
Compare
StaehliJ
force-pushed
the
451-handle-segment
branch
from
April 18, 2024 08:52
68d74be
to
cd30157
Compare
1 task
Tag isknown as a PillarboxData.
Chapter list will be done in another story.
StaehliJ
force-pushed
the
451-handle-segment
branch
from
April 19, 2024 08:30
a25687f
to
1021024
Compare
MGaetan89
reviewed
Apr 19, 2024
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/ChapterInfo.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PlayerCallbackFlow.kt
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/asset/BlockedInterval.kt
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/tracker/ChaptersTracker.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/PlayerCallbackFlow.kt
Fixed
Show fixed
Hide fixed
Player message from ChapterTracker is blocking the test player message
Code Coverage
Files
|
MGaetan89
approved these changes
Apr 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The goal of this PR is to introduce chapters and blocked intervals to Pillarbox. Every
MediaItem
have aPillarboxData
with all the metadata needed.PillarboxPlayer will seek immediately when it's playback position reach a
BlockedInterval
. Users can be notified when it happens throughPillarboxPlayer.Listener.onBlockIntervalReached
.Changes made
PillarboxPlayer.Listener.onBlockIntervalReached
to be notified when PillarboxPlayer has seeked because of aBlockInterval
.PillarboxPlayer.Listener.onCurrentChapterChanged
to listen current Chapter changes during playback.Player.getCurrentChapters
andPlayer.getChapterAtPosition
Player.getCurrentBlockedIntervals
andPlayer.getBlockedIntervalAtPosition
.Checklist
main
branch.