Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 12h45 stream in the demo app #498

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Update 12h45 stream in the demo app #498

merged 1 commit into from
Apr 17, 2024

Conversation

waliid
Copy link
Member

@waliid waliid commented Apr 16, 2024 •
edited
Loading

Pull request

Description

This PR updates the horizontal video example to a modern URN.

Changes made

  • Use recent 12h45 with improved image quality instead of an old 19h30.
  • Remove RSI live stream.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@waliid waliid requested review from MGaetan89 and StaehliJ April 16, 2024 12:40
@waliid waliid self-assigned this Apr 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Code Coverage

Overall Project 46.59% 🟢

There is no coverage information present for the Files changed

MGaetan89
MGaetan89 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

pillarbox-demo-shared/src/main/java/ch/srgssr/pillarbox/demo/shared/data/Playlist.kt Show resolved Hide resolved
@MGaetan89 MGaetan89 added this to the Demo milestone Apr 16, 2024
@MGaetan89 MGaetan89 added the enhancement New feature or request label Apr 16, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit b29689d Apr 17, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the update-streams branch April 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

@StaehliJ StaehliJ Awaiting requested review from StaehliJ

Assignees

@waliid waliid

Labels
enhancement New feature or request
Projects
Pillarbox
Archived in project
Milestone
Demo
Development

Successfully merging this pull request may close these issues.
2 participants
@waliid @MGaetan89