Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the multi player showcase #478

Merged
merged 13 commits into from
Apr 5, 2024
Merged

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Mar 20, 2024

Pull request

Description

This PR improves the multi player showcase in the following ways:

  • Only have one of the two players to play audio at a time
  • Clicking on the inactive player activates it, and disables the other one
  • A media notification is now shown with, linked with the current player
  • Only the analytics for the currently active player are sent

Changes made

  • Create a MultiPlayerViewModel to manage the players, the active state toggling, and the media notification
  • Add the missing android.permission.POST_NOTIFICATIONS permission in the pillarbox-demo manifest
  • Make the PlayerControls background control customisable
  • Update CurrentMediaItemTracker to support restarting tracking

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Mar 20, 2024 that may be closed by this pull request
1 task
Copy link

github-actions bot commented Mar 20, 2024

Code Coverage

Overall Project 55.25% -0.01% 🟢
Files changed 87.5% 🟢

Module Coverage
:pillarbox-player 73.15% -0.04% 🟢
Files
Module File Coverage
:pillarbox-player CurrentMediaItemTracker.kt 95.51% -0.45% 🟢

@MGaetan89 MGaetan89 force-pushed the 473-improve-multi-player-showcase branch from b5b87f8 to 8972814 Compare April 2, 2024 07:04
@MGaetan89 MGaetan89 force-pushed the 473-improve-multi-player-showcase branch from 8972814 to e2bec3f Compare April 4, 2024 15:03
@StaehliJ StaehliJ enabled auto-merge April 5, 2024 09:14
@StaehliJ StaehliJ self-requested a review April 5, 2024 09:14
@StaehliJ StaehliJ added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 86f7dce Apr 5, 2024
10 checks passed
@StaehliJ StaehliJ deleted the 473-improve-multi-player-showcase branch April 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve multi player showcase
2 participants