Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use movable content to swap players #472

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

StaehliJ
Copy link
Contributor

Pull request

Description

Use movableContentOf to swap players for multiple player showcase.

Changes made

  • Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

Copy link

github-actions bot commented Mar 14, 2024

Code Coverage

Overall Project 54% 🟢

There is no coverage information present for the Files changed

Copy link
Member

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit that mitigates the players from flickering while swapping. But it means that we go back to the previous approach of changing the player assigned to a PlayerView, instead of just moving the PlayerViews.
The flickering was already here before this PR, so if you prefer to keep your approach, I can revert my commit.

@MGaetan89 MGaetan89 added the enhancement New feature or request label Mar 15, 2024
@MGaetan89 MGaetan89 added this to the Demo milestone Mar 15, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 0edbc63 Mar 15, 2024
10 checks passed
@StaehliJ StaehliJ deleted the multi-player-swap-movable-content branch March 15, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants