Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

464 fix analytics event skip next or previous media item #465

Merged
merged 5 commits into from
Mar 12, 2024
Merged

464 fix analytics event skip next or previous media item #465

merged 5 commits into from
Mar 12, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Mar 12, 2024 •
edited by MGaetan89
Loading

Pull request

Description

The goal of this PR is to fix an issue with CurrentItemTracker that doesn't stop trackers when it receive a position discontinuity changed with different media item index.

Changes made

  • Self explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ requested a review from MGaetan89 March 12, 2024 10:04
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 53.38% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-player 69.24% 🟢
Files
Module File Coverage
:pillarbox-player CurrentMediaItemTracker.kt 92.15% 🟢

@MGaetan89 MGaetan89 linked an issue Mar 12, 2024 that may be closed by this pull request
Invalid event send when skip next or skip previous #464
Closed
1 task
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit b40b156 Mar 12, 2024
10 checks passed
@MGaetan89 MGaetan89 deleted the 464-fix-analytics-event-skip-element branch March 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid event send when skip next or skip previous
2 participants
@StaehliJ @MGaetan89