Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #461

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Update dependencies #461

merged 8 commits into from
Mar 8, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Mar 7, 2024

Pull request

Description

This PR updates the dependencies of the project:

Changes made

The update of Compose fixes our issue in Slider. So I've removed the @Stable from ProgressTrackerState.

For the update of Media3, I didn't see any change that requires an code change on our side. I went through the demo app, and test the various showcases, without noticing any issues. The only change that was directly relevant for us, is that now TestPillarboxRunHelper.playUntilStartOfMediaItem doesn't pause the media when the position is reached. So I've removed out custom TestPillarboxRunHelper.runUntilStartOfMediaItem to use that method instead.

The other updates are minor:

  • Coil improves its performance and fixes many bugs. The images are still loading and displayed in the TV demo app
  • JSON is used only in tests, which are still passing successfully

I've also updated the workflow running the Android tests on GitHub Actions to remove all the modules that no longer have any Android tests. This should speed up that step, by not running unnecessary tasks.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added the enhancement New feature or request label Mar 7, 2024
@MGaetan89 MGaetan89 added this to the 1.0.0 milestone Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Code Coverage

Overall Project 53.34% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 self-assigned this Mar 8, 2024
@MGaetan89 MGaetan89 marked this pull request as draft March 8, 2024 07:53
@MGaetan89 MGaetan89 marked this pull request as ready for review March 8, 2024 08:28
@StaehliJ StaehliJ enabled auto-merge March 8, 2024 09:15
@StaehliJ StaehliJ added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit ffe0d5d Mar 8, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the update_dependencies branch March 8, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants