-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #461
Merged
Merged
Update dependencies #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
…`TestPillarboxRunHelper.playUntilStartOfMediaItem`
StaehliJ
approved these changes
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2024
StaehliJ
approved these changes
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR updates the dependencies of the project:
Changes made
The update of Compose fixes our issue in
Slider
. So I've removed the@Stable
fromProgressTrackerState
.For the update of Media3, I didn't see any change that requires an code change on our side. I went through the demo app, and test the various showcases, without noticing any issues. The only change that was directly relevant for us, is that now
TestPillarboxRunHelper.playUntilStartOfMediaItem
doesn't pause the media when the position is reached. So I've removed out customTestPillarboxRunHelper.runUntilStartOfMediaItem
to use that method instead.The other updates are minor:
I've also updated the workflow running the Android tests on GitHub Actions to remove all the modules that no longer have any Android tests. This should speed up that step, by not running unnecessary tasks.
Checklist
main
branch.