Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comscore tracker tests #434

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Add comscore tracker tests #434

merged 3 commits into from
Feb 1, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 1, 2024 •
edited by MGaetan89
Loading

Pull request

Description

The goal of the PR is to add tests for ComScoreTracker.

Changes made

  • ComScoreTracker is testable.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ added this to the Test milestone Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited
Loading

Code Coverage

Overall Project 33.19% -0.08% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-core-business 46.11% -0.26% 🟢
Files
Module File Coverage
:pillarbox-core-business ComScoreTracker.kt 0.56% -2.97% 🟢

@StaehliJ StaehliJ requested a review from MGaetan89 February 1, 2024 09:44
@StaehliJ StaehliJ enabled auto-merge February 1, 2024 09:44
@MGaetan89 MGaetan89 assigned MGaetan89 and StaehliJ and unassigned MGaetan89 Feb 1, 2024
@StaehliJ StaehliJ added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 4fb1225 Feb 1, 2024
8 checks passed
@StaehliJ StaehliJ deleted the add-comscore-tracker-tests branch February 1, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees

@StaehliJ StaehliJ

Labels
None yet
Projects
Pillarbox
Archived in project
Milestone
Test
Development

Successfully merging this pull request may close these issues.
2 participants
@StaehliJ @MGaetan89