Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GitHub Workflows on macOS 14 #433

Closed
wants to merge 2 commits into from
Closed

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jan 31, 2024

Pull request

Description

Update the build.yml and nightly.yml GitHub Workflows to run on macos-14 instead of ubuntu-latest to compare the performance.
A comparison of the various GitHub hosted runners is available here.

Changes made

  • Self-explanatory

Note

In draft until we decide if it is interesting to merge or not.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

Copy link

github-actions bot commented Jan 31, 2024

Code Coverage

Overall Project 33.22% 🟢

There is no coverage information present for the Files changed

@MGaetan89
Copy link
Member Author

Build times seem fairly similar to what we currently have, and Android Tests are not passing. I'd say that it's not worth investing too much time on this now, since the benefit will is negligeable.

@MGaetan89 MGaetan89 closed this Jan 31, 2024
@MGaetan89 MGaetan89 deleted the github_workflow_macos branch January 31, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant