Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to pillarbox-player #432

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jan 31, 2024

Pull request

Description

This PR follows up on what has been initiated in #430, and add even more tests to the pillarbox-player module.

Changes made

  • Add new tests to the pillarbox-player module
  • Remove mocking of the Android SDK in the pillarbox-core-business, and pillarbox-player modules, to take advantage of Robolectric instead
  • Fix an issue in PillarboxMediaDescriptionAdapter where the Bitmap was not returned after being downloaded for the first time

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jan 31, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 31, 2024

Code Coverage

Overall Project 20.86% -0.83% 🟢
Files changed 13.19% 🟢

Module Coverage
:pillarbox-analytics 53.47% -1.05% 🟢
:pillarbox-player 24.75% -2.44% 🟢
Files
Module File Coverage
:pillarbox-analytics ComScoreSrg.kt 0% -7.12% 🟢
:pillarbox-player MediaItemTrackerRepository.kt 100% 🟢
MediaItemTrackerList.kt 96.23% 🟢
PendingIntentUtils.kt 0% -64.71% 🟢
TrackSelectionParameters.kt 0% 🟢
PillarboxMediaSessionService.kt 0% -2.96% 🟢
PillarboxMediaLibraryService.kt 0% -13.39% 🟢
PillarboxMediaDescriptionAdapter.kt 0% -19.79% 🟢
CurrentMediaItemTracker.kt 0% -6.93% 🟢

@MGaetan89 MGaetan89 enabled auto-merge January 31, 2024 16:15
@MGaetan89 MGaetan89 force-pushed the 425-update-code-coverage-of-pillarbox-player_2 branch from a2fe590 to 22cae9b Compare February 1, 2024 10:14
@MGaetan89 MGaetan89 added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit a049e86 Feb 1, 2024
8 checks passed
@MGaetan89 MGaetan89 deleted the 425-update-code-coverage-of-pillarbox-player_2 branch February 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code coverage of pillarbox-player
2 participants