Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add robolectric analytics tests #431

Merged
merged 13 commits into from
Jan 30, 2024
Merged

Add robolectric analytics tests #431

merged 13 commits into from
Jan 30, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jan 30, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to reduce the amount of AndroidTest by using Robolectric when an Android context is needed.

Changes made

Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ requested a review from MGaetan89 January 30, 2024 14:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

Code Coverage

Overall Project 31.51% -0.14% 🟢
Files changed 12.9% 🟢

Module Coverage
:pillarbox-analytics 52.97% -1.48% 🟢
Files
Module File Coverage
:pillarbox-analytics SRGAnalytics.kt 32.09% 🟢
ComScoreSrg.kt 0% 🟢
CommandersActSrg.kt 0% -11.54% 🟢

@StaehliJ StaehliJ enabled auto-merge January 30, 2024 14:56
@MGaetan89 MGaetan89 linked an issue Jan 30, 2024 that may be closed by this pull request
Improve analytics tests with robolectric #429
Closed
@StaehliJ StaehliJ added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit b992420 Jan 30, 2024
8 checks passed
@StaehliJ StaehliJ deleted the add-robolectric-analytics-tests branch January 30, 2024 16:01
MGaetan89 added a commit that referenced this pull request Jan 31, 2024
@StaehliJ @MGaetan89
Add robolectric analytics tests (#431)
ab3134e 
Co-authored-by: Gaëtan Muller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve analytics tests with robolectric
2 participants
@StaehliJ @MGaetan89