Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to pillarbox-core-business #419

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add unit tests to pillarbox-core-business #419

merged 1 commit into from
Jan 26, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jan 25, 2024 •
edited
Loading

Pull request

Description

This PR adds new unit tests to pillarbox-core-business.

Changes made

  • Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jan 25, 2024 that may be closed by this pull request
Update code coverage of pillarbox-core-business #414
Closed
@MGaetan89 MGaetan89 force-pushed the 414-update-code-coverage-of-pillarbox-core-business branch from c417ca2 to 859f2f0 Compare January 26, 2024 08:48
@github-actions GitHub Actions
Copy link

Code Coverage

Overall Project 31% -0.14% 🟢
Files changed 77.19% 🟢

Module Coverage
:pillarbox-core-business 46.29% -0.43% 🟢
Files
Module File Coverage
:pillarbox-core-business TotalPlaytimeCounter.kt 100% 🟢
ResourceNotFoundException.kt 100% 🟢
BlockReasonException.kt 90.91% 🟢
DefaultMediaCompositionDataSource.kt 84.25% 🟢
BlockReason.kt 65% 🟢
DefaultHttpClient.kt 28.7% 🟢
AkamaiTokenProvider.kt 0% -3.23% 🟢
AkamaiTokenDataSource.kt 0% -2.31% 🟢

@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 592f43f Jan 26, 2024
8 checks passed
@MGaetan89 MGaetan89 deleted the 414-update-code-coverage-of-pillarbox-core-business branch January 26, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update code coverage of pillarbox-core-business
2 participants
@MGaetan89 @StaehliJ