Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

412 update player tests with turbine #418

Merged
merged 9 commits into from
Jan 26, 2024
Merged

412 update player tests with turbine #418

merged 9 commits into from
Jan 26, 2024

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jan 25, 2024 •
edited
Loading

Description

The goal of this PR is to rewrite some tests with flow but with turbine.

Changes made

  • Change PlayerCallbackFlow.currentPositionAsFlow to send initial position when not playing.
  • Update flow tests with turbine.
  • Organize test in packages.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ requested a review from MGaetan89 January 25, 2024 16:45
@MGaetan89 MGaetan89 linked an issue Jan 25, 2024 that may be closed by this pull request
Update player tests with Turbine #412
Closed
@StaehliJ StaehliJ added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 21042aa Jan 26, 2024
8 checks passed
@StaehliJ StaehliJ deleted the 412-update-player-tests-with-turbine branch January 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update player tests with Turbine
2 participants
@StaehliJ @MGaetan89