Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize pillarbox-demo-tv structure and add missing examples #405

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jan 22, 2024

Pull request

Description

Following the work done in #393 for pillarbox-demo, the same changes have been applied to pillarbox-demo-tv.
This PR also moved the ExamplesViewModel to pillarbox-demo-shared, so it can be reused in pillarbox-demo-tv to show the missing protected examples.
Finally, it fixes some Lint warnings:

  • Convert icons to WebP
  • Disable monochrome launcher icon in the TV app, as it is not supported there

Changes made

Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 enabled auto-merge January 22, 2024 19:25
@MGaetan89 MGaetan89 added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 03fb75b Jan 23, 2024
8 checks passed
@MGaetan89 MGaetan89 deleted the 402-update-package-structure-of-the-tv-demo-app branch January 23, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add protected examples to the TV demo app Update package structure of the TV demo app
2 participants