Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize pillarbox-demo structure #398

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jan 19, 2024

Pull request

Description

This PR Reorganize the file structure of the pillarbox-demo module. It also renames some file, to make sure that every showcase has the Showcase suffix.

The new package structure more closely matches the UI of the demo app, to make it easier to find sample code:
Screenshot 2024-01-19 at 14 34 21

Changes made

  • Reorganize the file structure of pillarbox-demo
  • Remove support for Material 3's dynamic color

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jan 19, 2024 that may be closed by this pull request
2 tasks
@StaehliJ
Copy link
Contributor

StaehliJ commented Jan 19, 2024

Maybe for easier understanding the viewmodels can be inside the showcase file. So one showcase will have exactly one file.

#400

@StaehliJ StaehliJ added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 0c01535 Jan 19, 2024
8 checks passed
@StaehliJ StaehliJ deleted the 393-refactor-naming-in-showcases branch January 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor naming in showcases
2 participants