Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix player controls in demo tv #362

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Fix player controls in demo tv #362

merged 1 commit into from
Dec 11, 2023

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Dec 8, 2023 •
edited
Loading

Pull request

Description

The goal of this PR is to allow users of Pillarbox Demo TV to modify playback.

Changes made

  • Fix button from player view on TV to only toggle view and not do actions.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Dec 8, 2023 that may be closed by this pull request
Improve demo TV controls #361
Closed
1 task
@MGaetan89 MGaetan89 mentioned this pull request Dec 8, 2023
Merged
6 tasks
@StaehliJ StaehliJ added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit afaf87d Dec 11, 2023
7 checks passed
@StaehliJ StaehliJ deleted the 361-improve-demo-tv-controls branch December 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve demo TV controls
2 participants
@StaehliJ @MGaetan89