Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a menu to change environment in "Lists" on mobile #358

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Add a menu to change environment in "Lists" on mobile #358

merged 4 commits into from
Dec 6, 2023

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Nov 30, 2023 •
edited
Loading

Pull request

Description

This PR adds a menu in the toolbar in "Lists" in the demo app for mobile to change the environment (production, stage, test), similarly to what is done in pillarbox-apple.

Changes made

  • Add a menu in "Lists" to change the environment
  • Fix back arrow being visible in "Search"

Screenshots

Light mode Dark mode
070EDA49-037D-47BF-A464-C89498D07E87_1_201_a 6D1CE4A9-5A62-4795-8387-0F6E975ED498_1_201_a

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 30, 2023 that may be closed by this pull request
Add an environment selector in the "Lists" section #316
Closed
@MGaetan89 MGaetan89 force-pushed the 316-add-an-environment-selector-in-the-lists-section branch from 7747acb to 17a15b3 Compare December 5, 2023 10:30
@MGaetan89 MGaetan89 enabled auto-merge December 6, 2023 08:59
@MGaetan89 MGaetan89 added this pull request to the merge queue Dec 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2023
@MGaetan89 MGaetan89 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit c54e769 Dec 6, 2023
7 checks passed
@MGaetan89 MGaetan89 deleted the 316-add-an-environment-selector-in-the-lists-section branch December 6, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an environment selector in the "Lists" section
2 participants
@MGaetan89 @StaehliJ