Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move media icon type in the top left corner on TV #333

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

MGaetan89
Copy link
Member

Pull request

Description

In this PR, I've moved the media type icon in the top left corner of the media card on TV. I've also added the duration of the media in both demo apps.

Changes made

  • Move the media type icon in the top left corner of the media card on TV.
  • Display the media duration in both demo apps.
  • Move some display logic in pillarbox-demo-shared to reduce code duplication.

Screenshots

Description Light mode Dark mode
Media card on TV N/A Screenshot_20231122_110509 
Media card on mobile Screenshot_20231122_110634 Screenshot_20231122_110641

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 22, 2023 that may be closed by this pull request
@MGaetan89 MGaetan89 marked this pull request as draft November 22, 2023 10:25
@MGaetan89
Copy link
Member Author

I've put this PR in draft, so I can change the duration formatting logic to match what was explained here: SRGSSR/pillarbox-apple#644 (comment)

@MGaetan89 MGaetan89 marked this pull request as ready for review November 22, 2023 10:33
@MGaetan89 MGaetan89 merged commit 95ee6fb into main Nov 22, 2023
8 checks passed
@MGaetan89 MGaetan89 deleted the 326-move-media-icon-in-the-top-left-corner branch November 22, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move media icon in the top left corner
2 participants