Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise padding values #332

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

MGaetan89
Copy link
Member

Pull request

Description

As suggested in #328 (comment), I've grouped every padding values in a common place available under MaterialTheme.paddings.*.

Changes made

  • Added an extension on MaterialTheme to provide a Paddings instance with every supported paddings
  • Replaced every padding values in pillarbox-demo with the values from MaterialTheme.paddings

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 21, 2023 that may be closed by this pull request
@MGaetan89 MGaetan89 merged commit 29434e3 into main Nov 22, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 330-store-padding-values-in-a-common-place branch November 22, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store padding values in a common place
2 participants