Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align examples with pillarbox-apple #322

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

MGaetan89
Copy link
Member

Pull request

Description

This PR integrates the examples from pillarbox-apple, while maintaining the Android specific examples (Google streams, unified streams - DASH).
Since the current playlists are shared in various part of the demo apps, I've created specific ones for the "Examples" section to not impact the rest of the app.

Changes made

  • Integrate every examples from pillarbox-apple and add the Android specific examples
  • Created a Playlist.examplesPlaylists that contains every playlists to display in "Examples", and use it in both the mobile and TV demo apps
  • Refresh the design of the "Examples" section on mobile

Screenshots

Light mode Dark mode
Screenshot_20231120_093026 Screenshot_20231120_093107

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 20, 2023 that may be closed by this pull request
@MGaetan89 MGaetan89 merged commit 9e53977 into main Nov 20, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 312-align-examples-with-pillarbox-apple branch November 20, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align "Examples" with pillarbox-apple
3 participants