Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color schemes in the demo apps #321

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Nov 17, 2023

Pull request

Description

Create new color schemes for the demo, that are closer to the colors of pillarbox-apple.

Changes made

  • Create new color schemes (light/dark) in pillarbox-demo-shared
  • Use these new color schemes in pillarbox-demo-tv
  • Use these new color schemes in pillarbox-demo
  • Add support for dynamic colors in pillarbox-demo (the colors are generated dynamically based on the background of the device)
  • Update the template of the copyright header to avoid having the year in new files (improvement on top of Remove year from copyright info #301)

Screenshots

Description Dark mode Light mode
Dynamic colors (blue, demo) Screenshot_20231117_103547  Screenshot_20231117_103553
Dynamic colors (yellow, demo) Screenshot_20231117_103609 Screenshot_20231117_103616
Static colors (demo) Screenshot_20231117_103628 Screenshot_20231117_103634
Static colors (demo TV) Screenshot_20231117_103654 N/A

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 17, 2023 that may be closed by this pull request
@MGaetan89 MGaetan89 merged commit 2d37a68 into main Nov 17, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 302-change-colour-scheme-of-the-demo-apps branch November 17, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change colour scheme of the demo apps
2 participants