Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify navigation graph definition in "Lists" #305

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

MGaetan89
Copy link
Member

Pull request

Description

As reported by @waliid in #299 (comment), there is quite some code duplication in the demo apps in order to handle the various content list in the navigation graph definition. This PR simplifies that by making the code more generic.

Changes made

  • Introduce a ContentListFactory interface to group the code required to create a content list
  • Use that interface to dynamically create each relevant entry in the navigation graph definition

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 14, 2023 that may be closed by this pull request
@MGaetan89 MGaetan89 changed the title 298 integrate remaining parts of lists Simplify navigation graph definition in "Lists" Nov 14, 2023
@MGaetan89 MGaetan89 merged commit 2d9cf99 into main Nov 16, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 298-integrate-remaining-parts-of-lists branch November 16, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate remaining parts of "Lists"
2 participants