Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve navigation bar in the TV demo app #296

Merged

Conversation

MGaetan89
Copy link
Member

Pull request

Description

While working on #293, I discovered that there is already a component for TV to highlight an active item. So the goal of this PR is to simplify some of the changes made in #294.

Changes made

  • Simplify MainActivity by removing redundant nested Boxes and use a Column instead
  • Add previews to newly created components
  • Simplify TVDemoTopBar by using existing native components

Screenshots

New top bar with focus on the first element:
72DFE02D-E1CB-40EF-A711-EE32EADFB6DD_1_201_a

New top bar without focus and first element selected:
8992441C-64B5-46DF-9031-D736A3B90354_1_201_a

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 changed the title 292 add navigation bar to switch between examples and lists Improve navigation bar in the TV demo app Nov 9, 2023
@MGaetan89 MGaetan89 added this to the TV milestone Nov 9, 2023
Copy link
Member

@defagos defagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@MGaetan89 MGaetan89 merged commit 7209750 into main Nov 10, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 292-add-navigation-bar-to-switch-between-examples-and-lists branch November 10, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants