Improve navigation bar in the TV demo app #296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
While working on #293, I discovered that there is already a component for TV to highlight an active item. So the goal of this PR is to simplify some of the changes made in #294.
Changes made
MainActivity
by removing redundant nestedBox
es and use aColumn
insteadTVDemoTopBar
by using existing native componentsScreenshots
New top bar with focus on the first element:
New top bar without focus and first element selected:
Checklist
main
branch.