Use resize endpoint for images #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
defagos
reviewed
Nov 7, 2023
...-business/src/main/java/ch/srgssr/pillarbox/core/business/images/DefaultImageScaleService.kt
Outdated
Show resolved
Hide resolved
defagos
reviewed
Nov 7, 2023
| @@ -28,6 +28,7 @@ object MediaItemUrn { | |||
| MediaMetadata.Builder() | |||
| .setTitle(title) | |||
| .setSubtitle(subtitle) | |||
| // TODO Integrate `ImageScaleService` once we know if this class will be used or not | |||
There was a problem hiding this comment.
Is this a TODO for the future or has it been addressed (or not)?
There was a problem hiding this comment.
This class (MediaItemUrn) was created in September, but is currently not used.
I'd like to check its status with @StaehliJ, to know if it makes sense to update it, or if we should delete it, or if the change is not necessary here.
waliid
reviewed
Nov 7, 2023
| @@ -28,6 +28,7 @@ object MediaItemUrn { | |||
| MediaMetadata.Builder() | |||
| .setTitle(title) | |||
| .setSubtitle(subtitle) | |||
| // TODO Integrate `ImageScaleService` once we know if this class will be used or not | |||
There was a problem hiding this comment.
Hopefully @StaehliJ. I've given a bit more context here: #290 (comment)
defagos
approved these changes
Nov 7, 2023
waliid
approved these changes
Nov 7, 2023
MGaetan89
force-pushed
the
276-corebusiness-resize-url-from-service-image
branch
from
c22386b to
f9b685f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Images displayed in the player's notification are now resized using the dedicated service. For now, we use a width of 480px, and WEBP.
Changes made
Checklist
mainbranch.