Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests and linters for all modules #289

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Run tests and linters for all modules #289

merged 3 commits into from
Nov 7, 2023

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Nov 3, 2023 •
edited
Loading

Pull request

Description

The goal of this PR is to make sure that we run linters and unit tests for every modules in this project, and not only for pillarbox-demo.

Now Android Lint and Unit Tests are run for every modules: https://github.com/SRGSSR/pillarbox-android/actions/runs/6747173720

Changes made

  • Run Android Lint for every modules
  • Run Unit Tests for every modules

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Nov 3, 2023 that may be closed by this pull request
Run tests and linters for all modules #288
Closed
3 tasks
@MGaetan89 MGaetan89 merged commit f1157a5 into main Nov 7, 2023
4 checks passed
@MGaetan89 MGaetan89 deleted the 288-run-tests-and-linters-for-all-modules branch November 7, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests and linters for all modules
2 participants
@MGaetan89 @defagos