Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExoPlayer.Builder from PillarboxPlayer #285

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Nov 2, 2023

Pull request

Description

The goal of this PR is to remove some complexity to the integrator by removing ExoPlayer.Builder from PillarboxPlayer.
For SRG SSR integrators we provide a DefaultPillarbox that create a PillarboxPlayer that handle SRG content and setup SRGAnalytics trackers.

Changes made

  • Remove ExoPlayer.Builder from PillarboxPlayer constructor.
  • Add parameters to DefaultPillarbox to match PillarboxPlayer constructor parameters.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Nov 2, 2023 that may be closed by this pull request
4 tasks
@StaehliJ StaehliJ requested a review from MGaetan89 November 2, 2023 10:00
@StaehliJ StaehliJ merged commit ac03653 into main Nov 2, 2023
4 checks passed
@StaehliJ StaehliJ deleted the 283-remove-complexity branch November 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove complexity
2 participants