-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
233 add user consent #235
Merged
Merged
233 add user consent #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
defagos
reviewed
Sep 5, 2023
pillarbox-analytics/src/main/java/ch/srgssr/pillarbox/analytics/SRGAnalytics.kt
Outdated
Show resolved
Hide resolved
defagos
reviewed
Sep 5, 2023
pillarbox-analytics/src/main/java/ch/srgssr/pillarbox/analytics/SRGAnalytics.kt
Outdated
Show resolved
Hide resolved
defagos
reviewed
Sep 5, 2023
pillarbox-analytics/src/main/java/ch/srgssr/pillarbox/analytics/SRGAnalytics.kt
Outdated
Show resolved
Hide resolved
defagos
reviewed
Sep 5, 2023
pillarbox-analytics/src/main/java/ch/srgssr/pillarbox/analytics/SRGAnalytics.kt
Outdated
Show resolved
Hide resolved
defagos
approved these changes
Sep 5, 2023
Co-authored-by: Samuel Défago <[email protected]>
StaehliJ
force-pushed
the
233-add-user-consent
branch
from
September 6, 2023 09:22
ab12de2
to
a98ee19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This pull request allow integrators to specify persistent label to ComScore and CommandersAct. Those persistent labels can be use to transmit user consent. Persistent labels are send when analytics is initialized and when sending events.
Changes made
AnalyticsConfig
.Checklist
main
branch.