Correct use of std::move + rm Project.h

SPauly · Aug 27, 2024 · eaff08f · eaff08f
1 parent c6ecd3f
commit eaff08f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 301 deletions.
diff --git a/include/spauly/vccore/impl/math.h b/include/spauly/vccore/impl/math.h
@@ -122,7 +122,7 @@ class PolynomialFunc : public ParameterisedBaseFunc<T, S> {
       --inverse_iter;
     }
 
-    return std::move(y);
+    return y;
   }
 };
 

diff --git a/src/calculator.cpp b/src/calculator.cpp
@@ -30,7 +30,7 @@ CorrectionFactors Calculator::Calculate(const Parameters& p,
 
   // Validate the Input
   out.error_flag = ValidateInput(p_base);
-  if (out.error_flag != 0) return std::move(out);
+  if (out.error_flag != 0) return out;
 
   // Map the input values to the scales.
   double flow_pos = FitToScale(kFlowrateScale, p_base.flowrate, 0);
@@ -81,7 +81,7 @@ CorrectionFactors Calculator::Calculate(const Parameters& p,
     }
   }
 
-  return std::move(out);
+  return out;
 }
 
 Parameters Calculator::GetConverted(const Parameters& p,
@@ -99,7 +99,7 @@ Parameters Calculator::GetConverted(const Parameters& p,
   out.density =
       impl::ConvertToBaseUnit<DensityUnit>(impl::DoubleT(p.density), u.density);
 
-  return std::move(out);
+  return out;
 }
 
 const size_t Calculator::ValidateInput(const Parameters& p) const noexcept {
@@ -117,7 +117,7 @@ const size_t Calculator::ValidateInput(const Parameters& p) const noexcept {
     errors |= ErrorFlag::kViscosityError;
   }
 
-  return std::move(errors);
+  return errors;
 }
 
 const double Calculator::FitToScale(

diff --git a/src/project.cpp b/src/project.cpp
diff --git a/testing/conversion_functions_test.cpp b/testing/conversion_functions_test.cpp
@@ -91,7 +91,7 @@ std::string ConversionHelper(TestCasesMap& cases, _Unit from) {
     }
   }
 
-  return std::move(errors);
+  return errors;
 }
 
 TEST(ConversionFunctions, liters_per_minute) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -122,7 +122,7 @@ class PolynomialFunc : public ParameterisedBaseFunc<T, S> { @@
           --inverse_iter;
         }
-        return std::move(y);
+        return y;
       }
     };
@@ Expand Down @@