Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1
In the processes.py file, line 572, when train_log_interval is not provided it is set to len(training_dataset). Hence, the first part of the if-test is only True if iteration is a multiple of len(training_dataset).
However, pbar.total is also set to len(training_dataset) and thus the second test can never pass when iteration is equal to len(training_dataset), which is when the if-test should actually be succeeding. Should this not be:
if iteration % train_log_interval == 0 and pbar.total >= iteration:
Instead of:
if iteration % train_log_interval == 0 and pbar.total != iteration:
2
In the utils.py file, line 106, when the dataset does not explicitly provide event ids, all event ids should be selected.
However, event_ids is set to None and therefore line 106 results in an AttributeError:
events = events[[i for i in range(len(events)) if events[i, -1] in event_ids.keys()], :]