Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfixes #76

Closed
wants to merge 1 commit into from
Closed

bugfixes #76

wants to merge 1 commit into from

Conversation

wulfdewolf
Copy link

1

In the processes.py file, line 572, when train_log_interval is not provided it is set to len(training_dataset). Hence, the first part of the if-test is only True if iteration is a multiple of len(training_dataset).
However, pbar.total is also set to len(training_dataset) and thus the second test can never pass when iteration is equal to len(training_dataset), which is when the if-test should actually be succeeding. Should this not be:

if iteration % train_log_interval == 0 and pbar.total >= iteration:

Instead of:

if iteration % train_log_interval == 0 and pbar.total != iteration:

2

In the utils.py file, line 106, when the dataset does not explicitly provide event ids, all event ids should be selected.
However, event_ids is set to None and therefore line 106 results in an AttributeError:

events = events[[i for i in range(len(events)) if events[i, -1] in event_ids.keys()], :]

@wulfdewolf wulfdewolf closed this by deleting the head repository Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant