Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12578 Make region, district and GPS coordinates of environments mand… #12591

Merged
merged 3 commits into from
Oct 9, 2023
Merged

#12578 Make region, district and GPS coordinates of environments mand… #12591

merged 3 commits into from
Oct 9, 2023

Conversation

leventegal-she
Copy link
Contributor

…atory

Fixes #12578

MateStrysewske
MateStrysewske requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@MateStrysewske MateStrysewske left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good; however, please check your Android formatting, I'm pretty sure the formatter is not properly set up; correct the setup and re-format the files. Also, there are quite a few test failures because of the new validations.

@sormas-vitagroup
Copy link
Contributor

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=12591

@MateStrysewske MateStrysewske merged commit d037203 into development Oct 9, 2023
10 of 11 checks passed
@MateStrysewske MateStrysewske deleted the feature-12578-Make_region,_district_and_GPS_coordinates_of_environments_mandatory branch October 9, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateStrysewske MateStrysewske MateStrysewske approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make region, district and GPS coordinates of environments mandatory [1]
3 participants
@leventegal-she @sormas-vitagroup @MateStrysewske