Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11465 - Limit case duplicate merging comparison based on creation da… #11734

Conversation

sergiupacurariu
Copy link
Contributor

…te and archived status - removed disease index

Fixes #11465

…te and archived status - removed disease index
@sormas-vitagroup
Copy link
Contributor

@@ -12320,4 +12320,10 @@ ALTER TABLE testreport_history ADD COLUMN dateofresult varchar(255);

INSERT INTO schema_version (version_number, comment) VALUES (511, 'Add dateOfResult to TestReports #11453');

-- 2023-03-27 Limit case duplicate merging comparison based on creation date and archived status #11465
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code linting fails because of these changes

Copy link
Contributor Author

@sergiupacurariu sergiupacurariu Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is received due to a misconfiguration of CICD pipeline.

@leventegal-she leventegal-she self-requested a review March 27, 2023 11:02
@leventegal-she leventegal-she merged commit 1d0e672 into development Mar 27, 2023
@leventegal-she leventegal-she deleted the feature-11465_limit_case_duplicate_merging_on_creation_and_archive branch March 27, 2023 11:04
@MartinWahnschaffe
Copy link
Contributor

@sergiupacurariu @leventegal-she Are you convinced that removing the index improves the query in general? My fear is that similar to my suggested improvment with the sub query, this only improves the situation for some data constellations but not for others. How big is the impact of removing this index?

It looks like the index was added to improve a slow query for cases by disease for the dashboard when used with a lab officer (see #4307 (comment)). I don't think we should remove it wihtout checking this aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit case duplicate merging comparison based on creation date and archived status [3]
4 participants