Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable Automatic/Manual Case Classification Customization Per Disease [2] #13150

Closed
4 tasks done
markusmann-vg opened this issue Sep 30, 2024 · 4 comments · Fixed by #13152
Closed
4 tasks done
Assignees
Labels
feature A new feature to be developed (ticket type) qa-verified Issue has been tested and verified by QA

Comments

@markusmann-vg
Copy link

markusmann-vg commented Sep 30, 2024

Feature Description

Currently, it is not possible to configure the "Case Classification" and "Automatic Case Classification" options individually for each disease in SORMAS.
Implement the option to individually configure the "Case Classification" and "Automatic Case Classification" for each disease in SORMAS.
Allow the configuration to be managed through the SORMAS Properties settings file.
The following should be the default values:

  • Manual Case Classification Calculation: Enabled
  • Automatic Case Classification: Enabled

Added Value/Benefit

Introducing this functionality would greatly improve the workflows of public health authorities by allowing more flexibility in managing case classifications based on specific disease needs.
This feature will enable health departments to adjust case classification workflows according to the specific requirements of different diseases, increasing flexibility and efficiency in case management.

Acceptance Criteria

  • A configurable setting to enable/disable for all diseases at once:
  • A configurable setting for each disease in the SORMAS Properties to enable/disable:

Automatic Case Classification
Manual Case Classification Calculation

  • Defaults should be:

Manual Case Classification Calculation: Enabled
Automatic Case Classification: Enabled

  • SORMAS Admins should be able to customize these settings without any further technical intervention.

Implementation Details

No response

Mockups

No response

Additional Information

No response

@markusmann-vg markusmann-vg added the feature A new feature to be developed (ticket type) label Sep 30, 2024
@leventegal-she leventegal-she self-assigned this Sep 30, 2024
@markusmann-vg markusmann-vg changed the title Enable Case Classification and Automatic Case Classification Customization Per Disease Enable/Disable Automatic/Manual Case Classification Customization Per Disease Oct 1, 2024
@markusmann-vg markusmann-vg changed the title Enable/Disable Automatic/Manual Case Classification Customization Per Disease Enable/Disable Automatic/Manual Case Classification Customization Per Disease [2] Oct 1, 2024
leventegal-she pushed a commit that referenced this issue Oct 3, 2024
@leventegal-she
Copy link
Contributor

leventegal-she commented Oct 3, 2024

Added configuration properties:

caseClassification.ALL
caseClassification.{Disease}: eg. caseClassification.CORONAVIRUS, caseClassification.CHOLERA, etc.

Possible values:
DISABLED, MANUAL, AUTOMATIC, MANUAL_AND_AUTOMATIC

To be added on the release notes

Braking change

The configuration property feature.automaticcaseclassification has been removed but the default configuration didn't change, meaning automatic classification is enabled by default
For disabling it caseClassification.ALL=DISABLED or caseClassification.ALL=MANUAL must be set

@XavCol
Copy link

XavCol commented Oct 3, 2024

The customization per disease should include the archive period and deletion period too.

@markusmann-vg
Copy link
Author

@xavier-calland
This cannot be included in this ticket as it is far more complex and this feature would imply huge impact on the whole SORMAS system regarding data protection and deletion concept. If this is needed, we should create an epic "Disease Management" where this configuration option is one task to do.
This should also be discussed with the SORMAS Foundation and it could also be prepared by the SF.

leventegal-she added a commit that referenced this issue Oct 14, 2024
…ual-case-classification-ustomization-per-disease

#13150 automatic manual case classification customization per disease
@markusmann-vg markusmann-vg added this to the Sprint 2 - 1.99.0 milestone Oct 29, 2024
@richardbartha
Copy link
Contributor

richardbartha commented Oct 29, 2024

Tested on localhost version 1.99.0 - SNAPSHOT (https://github.com/SORMAS-Foundation/SORMAS-Project/commits/0c557021cc987a83391e4d054f44f55ede18e358)
Work correctly as described in the ticket, however there are edge cases that should be handled somehow in the future! @markusmann-vg @
example: a case having multiple pathogen tests with different diseases that whould trigger automatic case clasification or manual calculation is needed, if you change the given case disease the automatic classification and manual calculation does not work correctly it always resets to default "not yet classified"

@richardbartha richardbartha added the qa-verified Issue has been tested and verified by QA label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature to be developed (ticket type) qa-verified Issue has been tested and verified by QA
Projects
None yet
5 participants
@markusmann-vg @leventegal-she @richardbartha @XavCol and others