-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[setting] Route 및 절대 경로 설정 #6
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
수고하셨습니다! 깔끔하게 잘 해주셨네요. 예시 코드) const authPages = {
LOGIN: '/',
SIGN_UP: '/signup',
};
const myPagePages = {
MY_PAGE: '/users/me',
MY_PAGE_INFO: '/users/me/info',
}; 이렇게 상수화를 해서 아래와 같이 사용하는 방법도 있을 것 같아서 의견 내봅니다! const authRoutes: RouteType[] = [
{
path: routePath.LOGIN,
element: <Login />,
},
{
path: routePath.SIGN_UP,
element: <SignUp />,
},
]; |
저도 해당 의견에 동의합니다. src/router/routesConfig.ts // routesConfig.ts
export const ROUTES_CONFIG = {
home: {
title: 'Home',
path: '/home',
},
onboarding: {
title: 'Onboarding',
path: '/onboarding',
},
timer: {
title: 'Timer',
path: '/timer',
},
}; 위와 같이 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
최고 !! 고생하셨습니당
저도 진혁 님 의견처럼 상수 사용했을 때 더 편리하고 좋았던 것 같아요 :)
📌 Related Issues
📄 Tasks
✅ PR Point (To Reviewer)
📷 Screenshot
(테스트용 파일들을 삭제 후 커밋함)
🔔 ETC