Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device/celestica]: Add support for fan/voltage event to questone2bd get_change_event api #196

Merged
merged 5 commits into from
Jul 16, 2020
Merged

[device/celestica]: Add support for fan/voltage event to questone2bd get_change_event api #196

merged 5 commits into from
Jul 16, 2020

Conversation

mudsut4ke
Copy link

@mudsut4ke mudsut4ke commented Jul 3, 2020 •
edited
Loading

- What I did

  • Implement polling method to get fan insert/remove event in questone2bd platform api
  • Implement polling method to get voltage over threshold event in questone2bd platform api

- How I did it

  • Modify get_change_event() in platform chassis.
  • Add event.py to store VoltageEvent, FanEvent and SfpEvent class

- How to verify it

@mudsut4ke mudsut4ke changed the title [device/celestica]: update questone2bd get_change_event api to suppor… [device/celestica]: Add support for fan/voltage event to questone2bd get_change_event api Jul 9, 2020
@mudsut4ke mudsut4ke self-assigned this Jul 9, 2020
@mudsut4ke mudsut4ke added the enhancement New feature or request label Jul 9, 2020
@mudsut4ke mudsut4ke requested a review from pphuchar July 9, 2020 08:57
@mudsut4ke mudsut4ke marked this pull request as ready for review July 9, 2020 08:57
pphuchar
pphuchar requested changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@pphuchar pphuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments.

device/celestica/x86_64-cel_questone2bd-r0/sonic_platform/chassis.py Outdated Show resolved Hide resolved
device/celestica/x86_64-cel_questone2bd-r0/sonic_platform/chassis.py Outdated Show resolved Hide resolved
device/celestica/x86_64-cel_questone2bd-r0/sonic_platform/chassis.py Outdated Show resolved Hide resolved
@mudsut4ke mudsut4ke requested a review from pphuchar July 14, 2020 08:14
@mudsut4ke
Copy link
Author

@pphuchar , Please review a0b6ecf

pphuchar
pphuchar approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@pphuchar pphuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprroved.

@mudsut4ke mudsut4ke merged commit 66877d3 into SONIC-DEV:201911_cel_wb Jul 16, 2020
mudsut4ke pushed a commit that referenced this pull request Mar 16, 2021
@Junchao-Mellanox
[snmpagent] Update submodule pointer for snmpagent (sonic-net#6850)
d76d74e 
183162f Fix issue: expect redis pubsub data to be str type instead of bytes type (#196)

#### Why I did it

Update submodule pointer for snmpagent to include PR sonic-net/sonic-snmpagent#196 

#### How I did it

Update submodule pointer for snmpagent

#### How to verify it

Run build
jerseyang pushed a commit that referenced this pull request Jun 4, 2021
@Junchao-Mellanox
[submodule][202012]: Update submodule pointer for snmpagent (sonic-ne…
38a0139 
…t#6954)

183162f Fix issue: expect redis pubsub data to be str type instead of bytes type (#196)

#### Why I did it

Update submoduel for snmpagent for 202012 branch since there is not 202012 branch for snmpagent

#### How I did it

Update submodule pointer

#### How to verify it

Run build
jerseyang pushed a commit that referenced this pull request Jun 4, 2021
@daall
[202012][submodule] Update sonic-linux-kernel submodule (sonic-net#7013)
5263478 
- Unset CONFIG_THERMAL_STATISTICS to prevent kernel crash (#199)
- [dni_dps460] Add attributes to retrieve PMBus status command codes (#197)
- [mellanox]: Backport new kernel patches (#195)
- [ci]: build amd64/armhf/arm64 for CI build (#196)
- Fix read and write failure to ‘fan1_target’ attribute of ‘dni_dps460’ driver. (#183)

Signed-off-by: Danny Allen <[email protected]>
mudsut4ke pushed a commit that referenced this pull request Sep 9, 2021
@Junchao-Mellanox
[sonic-platform-common] Update submodule (sonic-net#7868)
be5fc77 
7670b49 [sonic_platform/sfp_base] Add common definition for get SFP error status (#194)
1336598 [CI] sonic-config-engine now depends on SONiC YANG packages (#198)
f57fee4 Add to check pcie configuration revision to get the right configuration. (#195)
4e3a0a0 Fix typo for midplane APIs. (#196)
fc2e9e2 [eeprom_tlv_info] Optimize EEPROM data process by using visitor pattern (#193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pphuchar pphuchar pphuchar approved these changes

Assignees

@mudsut4ke mudsut4ke

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mudsut4ke @pphuchar