Update package.json #254
Merged
Update package.json #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean that only updating snappy within this |
|
@haio can see this pr and merge the pull request? |
|
@kadishmal I haven't seen any issues using this project as a consumer or producer since updating snappy on Node 4.x - I haven't done a ton of testing it has been a week or two. Our code is in internal pilot (we had it working on 0.11.x branch), and have had some decent usage. |
|
@tb01923 merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My testing looks to show that an upgrade to [email protected] works with kafka-node on NodeJs version 4.x - reference this issue I created
#253